Migrate 'entra license list' to Zod Closes #6905 #6968
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for opening the PR 🚀 |
MartinM85
requested changes
Oct 5, 2025
There was a problem hiding this comment.
Hi @nirav-raval, thank you for the contribution.
Looks good overall, just a few tiny things to consider.
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the entra license list command to use Zod for schema validation, addressing issue #6905. This is part of a broader effort to standardize command validation using Zod across the CLI for Microsoft 365 codebase.
- Added Zod schema support to the EntraLicenseListCommand class
- Updated test file to validate the new schema implementation
- Enhanced test coverage with additional validation scenarios
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/m365/entra/commands/license/license-list.ts | Added Zod imports, schema definition, and schema getter method |
| src/m365/entra/commands/license/license-list.spec.ts | Updated tests to use Zod schema validation and added new test cases |
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
MartinM85
approved these changes
Oct 23, 2025
MartinM85
added
pr-merged
hacktoberfest-accepted
|
Merged manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Title
Migrate 'entra license list' to Zod Closes #6905. Closes #6905
Linked Issue
Closes #6905